Skip to content

Conversation

@zvonkok
Copy link
Collaborator

@zvonkok zvonkok commented Jan 14, 2026

release: Enable Immutable Releases

@zvonkok zvonkok marked this pull request as ready for review January 14, 2026 23:17
Copilot AI review requested due to automatic review settings January 14, 2026 23:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements immutable releases by ensuring that releases are created as drafts first, then published only after all assets (binaries, signatures, provenance, and release notes) have been uploaded successfully. This prevents partial releases from being visible to end users.

Changes:

  • All release operations now interact with draft releases until final publication
  • New publish-release job publishes the draft release as the final step
  • Signature verification now runs after publication to ensure release integrity
Comments suppressed due to low confidence (1)

.github/workflows/release.yaml:49

  • The preflight check at line 46 will fail if a draft release already exists from a previous failed workflow run. The check should either exclude draft releases or delete existing draft releases before proceeding. Consider adding --exclude-drafts flag or checking the release state and deleting drafts for the tag before failing.
      - name: Fail if Release already exists for this tag
        env:
          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        shell: bash
        run: |
          set -euo pipefail
          TAG="${{ steps.reltag.outputs.tag }}"
          if gh release view "$TAG" --repo "${{ github.repository }}" >/dev/null 2>&1; then
            echo "Release $TAG already exists. Aborting to avoid overwrite." >&2
            exit 1
          fi

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
@zvonkok zvonkok merged commit 7aa3411 into NVIDIA:main Jan 14, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant